This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat($animate): animate dirty, pristine, valid, invalid for form/fields #5378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
Add css animations when form or field status change to/from dirty, pristine, valid or invalid. This works like animation system present with ngClass, ngShow, etc.
|
Is there something I can do to help you integrate this PR ? |
|
Now that the class-based animation fixes have been made in 1.2.13, we can merge this in. Will you be around later today incase of fixes? Sorry for the short notice. |
|
Great news :-) |
|
Alright so the code is great. We're in a bit of a hurry to get this in for tomorrow's release so I'll just redo the test and merge it in. |
matsko
pushed a commit
to matsko/angular.js
that referenced
this pull request
Feb 28, 2014
Add css animations when form or field status change to/from dirty, pristine, valid or invalid. This works like animation system present with ngClass, ngShow, etc. Closes angular#5378
matsko
pushed a commit
to matsko/angular.js
that referenced
this pull request
Feb 28, 2014
Add css animations when form or field status change to/from dirty, pristine, valid or invalid. This works like animation system present with ngClass, ngShow, etc. Closes angular#5378
|
Here is the updated PR with fixes to the tests and docs. It has also been rebased onto master. |
|
Closing this for now. Your name is on the new PR commit as well. |
matsko
pushed a commit
to matsko/angular.js
that referenced
this pull request
Feb 28, 2014
Add css animations when form or field status change to/from dirty, pristine, valid or invalid. This works like animation system present with ngClass, ngShow, etc. Closes angular#5378
matsko
pushed a commit
to matsko/angular.js
that referenced
this pull request
Feb 28, 2014
Add css animations when form or field status change to/from dirty, pristine, valid or invalid. This works like animation system present with ngClass, ngShow, etc. Closes angular#5378
matsko
pushed a commit
that referenced
this pull request
Feb 28, 2014
Add css animations when form or field status change to/from dirty, pristine, valid or invalid. This works like animation system present with ngClass, ngShow, etc. Closes #5378
|
MERGED |
|
Landed as 3344396 |
|
Yeah! Thanks a lot! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add css animations when form or field status change to/from dirty,
pristine, valid or invalid. This works like animation system present
with ngClass, ngShow, etc.